Fix Windows packaging when signing isn't provided, update app icon on Windows#1055
Merged
Conversation
Merged
xxyy2024
pushed a commit
to xxyy2024/waveterm_aipy
that referenced
this pull request
Jun 24, 2025
… Windows (wavetermdev#1055) This adds a new app icon for windows that is less Mac-like and it also fixes a bug in the electron-builder.config.cjs file which would cause the packaging step to crash if it was missing the signing env vars, rather than just not signing the package. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new app icon for windows that is less Mac-like and it also fixes a bug in the electron-builder.config.cjs file which would cause the packaging step to crash if it was missing the signing env vars, rather than just not signing the package.